Skip to content

Deprecate "bean-report_ledger" ad "bean-report_hledger" toolchains#29

Merged
trevorld merged 8 commits into
masterfrom
upkeep
Mar 28, 2026
Merged

Deprecate "bean-report_ledger" ad "bean-report_hledger" toolchains#29
trevorld merged 8 commits into
masterfrom
upkeep

Conversation

@trevorld

@trevorld trevorld commented Mar 28, 2026

Copy link
Copy Markdown
Owner
  • bean-report was removed from beancount in 2020 so deprecate the toolchains that use it. Use the "beancount" toolchain that uses bean-query instead.
  • Set up air settings and reformat code files
  • Rename filenames to end in .R
  • Update CI actions
  • Reformat cran-comments.rst to cran-comments.md
  • Update to {testthat} v3 and split up tests to match test file to R directory file correspondence

@codecov-commenter

codecov-commenter commented Mar 28, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 87.58389% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.58%. Comparing base (caebc24) to head (ef69907).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
R/register.R 87.82% 28 Missing ⚠️
R/zzz.R 0.00% 9 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (caebc24) and HEAD (ef69907). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (caebc24) HEAD (ef69907)
10 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #29       +/-   ##
===========================================
- Coverage   98.59%   87.58%   -11.02%     
===========================================
  Files           4        5        +1     
  Lines         214      298       +84     
===========================================
+ Hits          211      261       +50     
- Misses          3       37       +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

trevorld and others added 5 commits March 28, 2026 00:15
- Split test-ledger.R into test-register.R and test-net_worth.R
- Convert cran-comments.rst to cran-comments.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add `Config/testthat/edition: 3` to DESCRIPTION
- Remove deprecated `context()` calls

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…olchains

`bean-report` was removed from `beancount` in 2020; use the "beancount" toolchain instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@trevorld trevorld changed the title Deferred maintenance Deprecate "bean-report_ledger" ad "bean-report_hledger" toolchains Mar 28, 2026
@trevorld
trevorld merged commit f5e2d65 into master Mar 28, 2026
5 checks passed
@trevorld
trevorld deleted the upkeep branch March 28, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants