Implement bulk generation module#17
Open
AusIV wants to merge 4 commits intotreyhunner:masterfrom
Open
Conversation
I needed to generate several million names for a sample dataset, and looking up names out of the file every time was very time consuming. I left the original logic untouched, as it's the best approach for a quick, one-off lookup. I've added a separate module, 'names.bulk' which offers the same interface, but caches the entire file in memory and picks names with a binary search instead of a scan.
Author
|
I'm a bit perplexed. The Travis-CI build seems to be failing on Python 3.2 on something that has nothing to do with my changes. It looks like the coverage package is failing on Python 3.2 |
|
@treyhunner this looks like a great PR |
|
So I failed to bother to look at PRs before writing my own ([WIP]) in #23 which is 'similar' to this. Here at least a bisect is used but I think the |
|
@treyhunner Any chance we could approve this PR? This looks like a big performance boost on apps that call the library repeatedly. Anything I could do to help if QA needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to generate several million names for a sample dataset,
and looking up names out of the file every time was very time
consuming.
I left the original logic untouched, as it's the best approach for
a quick, one-off lookup. I've added a separate module, 'names.bulk'
which offers the same interface, but caches the entire file in memory
and picks names with a binary search instead of a scan.
Should resolve: #3