Added Ukrainian, Ukrainian in Latin, Russian and Russian in Latin names support.#20
Open
sikrinick wants to merge 1 commit intotreyhunner:masterfrom
Open
Added Ukrainian, Ukrainian in Latin, Russian and Russian in Latin names support.#20sikrinick wants to merge 1 commit intotreyhunner:masterfrom
sikrinick wants to merge 1 commit intotreyhunner:masterfrom
Conversation
…es support. Just first names and last names. It is possible to get name of certain local by specifying, same way as with gender. Possible locales: en, ua, ua-latin, ru, ru-latin Statistics of slavic name usage was taken from open sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Magic number antipattern #18 issue. Now this number will be taken as cummulative wage of second row from end of current file.
Just first names and last names.
It is possible to get name of certain local by specifying, same way as with gender.
Possible locales:
en, ua, ua-latin, ru, ru-latin
Statistics of slavic name usage was taken from open sources.
By default,
locale = "en"andgender = Noneso gender will be chosen randomly as in current version.Nevertheless, for slavic names you have to set gender, because lastname changes due to gender, or ValueError will be raised.
Example of syntax: