Skip to content

chore(dedupe): remove knowledge-manager/search reimplementations, thin command entrypoints — 1.4.0 - #24

Merged
treylom merged 9 commits into
mainfrom
chore/dedupe-km-search-1.4.0
Sep 4, 2026
Merged

treylom merged 9 commits into
mainfrom
chore/dedupe-km-search-1.4.0

Conversation

@treylom

@treylom treylom commented Sep 4, 2026

Copy link
Copy Markdown
Owner

What

  • A1 — removed ThisCode's own knowledge-management / vault-search implementations: 7 skill directories, 10 .agents/*.yaml specs and commands/search.md (25 tracked files). Knowledge management and vault search are provided by the knowledge-manager plugin (treylom/tofukyung-plugins).
  • A2 — removed .agents/cmd-thiscode-setup.yaml as well, so all four slash-command wrapper specs are gone. /thiscode:setup stays declared by .agents/bootstrap.yaml.
  • A4 — kept .agents/model-router.yaml; fixed tests/agents/test-router-yaml.sh, which pointed at a file that has not existed since the 2026-05-16 rename (.agents/thiscode-model-router.yaml). That test was red on main and is green here.
  • A3 — not applied. Thinning commands/init.md / commands/slack-configure.md turns two existing tests red (tests/init/test-commands-init.sh, tests/init/bot-launcher.test.mjs), so the change was reverted per the order's conditional. See the report for details.
  • Release — 1.3.2 → 1.4.0 in .claude-plugin/plugin.json and .claude-plugin/marketplace.json (feature removal = minor).

Reference cleanup

Every place that named a removed object was updated: README (en/ko) incl. a new install pointer under the role-boundary paragraph, AGENTS.md, GEMINI.md, docs/*, hermes-plugin/*, package.json, scripts/lib/codexsync.mjs, scripts/sync-skills-to-codex.sh, skills/help, skills/slack-configure, skills/thiscode_agy, and the test suite. agents.yaml was regenerated (17 → 6 agents), which also clears the dead cmd-search entry. Eight test files that only ever exercised the removed skills were deleted; the .agents count assertion was updated to the measured value.

The one remaining mention lives in docs/RECENT-CHANGES.md, a dated change log — kept on purpose as a historical record.

Verification

Gate Result
npm test 265 tests, 0 fail (253 pass / 12 skipped) — same as the base commit
bash scripts/install-browser-gate.sh --self-test 28/28
bash scripts/validate-agents.sh PASS (count=6)
node scripts/check-agents-index.mjs PASS (count=6)
tests/agents/* (6 scripts) all PASS, including the previously-red router test

Draft — not ready for review yet.

treylom and others added 3 commits September 5, 2026 01:03
Knowledge management and vault search move to the km plugin
(treylom/tofukyung-plugins). Removed 7 skill directories, 10 .agents specs
and commands/search.md, plus the wrapper meta .agents/cmd-thiscode-setup.yaml
(A2 — /thiscode:setup stays declared by bootstrap.yaml). References across
README (en/ko), docs, hermes-plugin, scripts and tests updated to point at the
km plugin; agents.yaml regenerated (17 -> 6). Fixed the router yaml test to
point at .agents/model-router.yaml (A4 — model-router itself is kept).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Feature removal (km/search skills move to the km plugin) is a minor bump.
Both .claude-plugin/plugin.json and .claude-plugin/marketplace.json go
1.3.2 -> 1.4.0.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The 8-Phase table and the install dispatch list still sent Phase 5 to a
km-at skill that A1 removed from this repo. Both lines now point at the km
plugin's Mode R preflight, with a note to fall back to the README install
pointer when the plugin is absent.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
treylom and others added 6 commits September 5, 2026 02:49
… knowledge/search (B1/B2/B5)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…runtime with manifest (+ tests) (B3/B4)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@treylom
treylom marked this pull request as ready for review September 4, 2026 18:44
@treylom
treylom merged commit 70a0100 into main Sep 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant