Text wrapping and Banner fix, fixes #14 and fixes #11 respectively#18
Merged
trintlermint merged 3 commits intomainfrom Apr 5, 2026
Merged
Text wrapping and Banner fix, fixes #14 and fixes #11 respectively#18trintlermint merged 3 commits intomainfrom
trintlermint merged 3 commits intomainfrom
Conversation
…tially so now paragraph wraps correctly
There was a problem hiding this comment.
Pull request overview
This PR updates several FTXUI screens to improve text wrapping and fix layout/scroll behavior (notably for banner/progress and long choice text), addressing the issues referenced in #14 and #11.
Changes:
- Replace
framewithyframein multiple scrollable panels to constrain scrolling to vertical only. - Use
paragraph(... ) | flexfor answer/choice rendering in quiz and question-detail screens to enable proper wrapping. - Move the quiz progress gauge into the non-scrolling header area so it behaves like a fixed banner element.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/screens/save_confirm.cpp | Use yframe for the diff preview panel to keep scrolling vertical. |
| src/screens/remove_question.cpp | Use yframe for the question list panel to constrain scrolling to vertical. |
| src/screens/quiz.cpp | Wrap choice text with paragraph + flex, move progress gauge into header, and use yframe for the scrollable body. |
| src/screens/quit_confirm.cpp | Use yframe for the diff preview panel when quitting with unsaved changes. |
| src/screens/manual.cpp | Use yframe for the manual content panel to keep scrolling vertical and avoid layout issues. |
| src/screens/list_questions.cpp | Use yframe for list/detail panels and wrap choice text in the detail view. |
| src/screens/edit_choice.cpp | Wrap choice text with paragraph + flex and use yframe for the overall scroll region. |
| src/screens/change_answer.cpp | Wrap choice text with paragraph + flex and use yframe for the overall scroll region. |
| src/screens/add_question.cpp | Use yframe for the overall scroll region. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.