This repository was archived by the owner on Aug 15, 2020. It is now read-only.
Open
Conversation
Add support for altType in CalendarProperty. This way we can use two different types for DTSTART (DATE-TIME and DATE). When setDate() is called with an undefined end parameter, add the DTSTART property using its altType and do not add a DTEND or DURATION property.
Member
|
Thank you for your contribution. I apologize for the poor state of the documentation for this project; all-day events are in fact supported. There are two ways to cause dates to be output as just a DATE value with no time component:
I do like your enhancement to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thanks for a great node module!
The project that I'm working on needed support for all day events. In an effort to get that working, I added support for an altType in CalendarProperty. This way we can use two different types for DTSTART (DATE-TIME and DATE). I then changed setDate() so that, when it is called with an undefined end parameter, it adds the DTSTART property using its altType (DATE) and does not add a DTEND or DURATION property. This makes the event appear as an all day event in my tests (using Apple's calendar app). This method of creating an all day event is mentioned in the RFC in section 3.6.1, page 53.
Hopefully this fits in with the direction you're going with the module, but let me know if it doesn't or if there's something you think should be implemented differently.