Fix string substitution after variant application#68
Open
Rall3n wants to merge 2 commits intotritum:masterfrom
Open
Fix string substitution after variant application#68Rall3n wants to merge 2 commits intotritum:masterfrom
Rall3n wants to merge 2 commits intotritum:masterfrom
Conversation
* Move processing logic to implementation, hook still acting as trigger * Add `beforeRendering` hook for additional reprocessing and cleanup
Rall3n
force-pushed
the
better-fixed-variants
branch
from
a77411e to
03233ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes string substitution after variants have been applied by adding the
beforeRenderinghook.To also support finishers, a custom
LinkedCheckboximplementation class has been introduced with an overwrite of thesetOptionsmethod. String substitution is re-applied if the argument$resetValidatorsistrue. As of current TYPO3 source this only ever happens when variants are being applied.For this, all of the processing logic of the
FormElementLinkResolverHookhas been moved to theLinkedCheckboximplementation class, with its hook methods still functioning as triggers for processing.Fixes #61