Update BoundaryErrors.f90 - #171
Conversation
Change the error output to be easy to plot the error by segement.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 78.25% 78.25% -0.01%
==========================================
Files 83 83
Lines 12387 12387
Branches 2 2
==========================================
- Hits 9694 9693 -1
- Misses 2693 2694 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrewwinters5000
left a comment
There was a problem hiding this comment.
Having access to the error values is good for visualization. Are the gStart and gEnd values of the parametrization variable t? So, for plotting one needs access to the boundary parametric curves and/or polynomials?
|
Yes, those are the parametrization values. One can then use the model to compute the physical space locations. Alternatively, if you think it would be better, I could write out the physical space locations. (Or both.) That would eliminate a visualization step. |
|
Adding the physical space locations would save a step and make the visualization easier. |
|
Will do. |
Add physical space positions of the segment end points. Also write out the number of boundary curves and segments per curve so that all information is available in the file without having to refer to the model. A header was added to `WriteBoundaryErrors' to describe the file format.
|
In the docs for the error controlled meshing it says that
but one the |
|
I guess I removed the point wise error output. I was using that primarily for development, and don't see the need for it now. It can always be added back later if anyone sees the need. So I say just remove the reference from the docs. |
Okay, I assumed it was the case that the pointwise error was useful in the development. I think the integrated value along a segment is sufficient to highlight the "problem" elements along a boundary in terms of the L2 or H1 errors. I will update the docs. |
|
I agree. I think that is sufficient. |
… had the wrong keyword for stats file
DavidAKopriva
left a comment
There was a problem hiding this comment.
Looks fine. Maybe replace "Stats and boundary errors not written" with "Stats and boundary errors are not written"
Change the error output to be easy to plot the error by segment.