Scanner error messages - #175
Merged
Merged
Conversation
Add procedures and their tests to check for the proper formatting for the "connect" keword in the chain definitions.
Add checking of the connect format string before scanning for breaks. Post an exception if there is a problem, otherwise using the default segmentation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 78.25% 78.34% +0.09%
==========================================
Files 83 83
Lines 12387 12463 +76
Branches 2 2
==========================================
+ Hits 9693 9764 +71
- Misses 2694 2699 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrewwinters5000
requested changes
Aug 14, 2026
andrewwinters5000
left a comment
andrewwinters5000
left a comment
Member
There was a problem hiding this comment.
Looks good and nice to have these sanity checks on the input. I just left a comment about a docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connect string is now tested for format errors and error messages are posted if they do not comply.