Find joint problem - #179
Merged
Merged
Conversation
Add procedures and their tests to check for the proper formatting for the "connect" keword in the chain definitions.
Add checking of the connect format string before scanning for breaks. Post an exception if there is a problem, otherwise using the default segmentation.
Fix spelling
Found the bug where curve joints were not stuck to a node. Removed the procedure that did that. Added new procedures to use recently added boundary node gathering to smooth the distribution of nodes along a curve. This should get rid of very narrow edges along a boundary curve.
Fix memory deallocation error
Remove code that caused the Segmented example to fail.
…/HOHQMesh into findJointProblem
Switched insertion sort to pointers. Added QuickSort, but it is slower, so am commenting it out for now.
The number of smoothing steps for the boundary smoothing has been renamed and moved to ProgramGlobals.
With the new boundary smoothing, most meshes have changed slightly, so the benchmark data for the mesh integration tests have been rerun.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 78.34% 78.17% -0.18%
==========================================
Files 83 83
Lines 12463 12497 +34
Branches 2 2
==========================================
+ Hits 9764 9769 +5
- Misses 2699 2728 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove (comment) unused code.
andrewwinters5000
approved these changes
Aug 24, 2026
andrewwinters5000
left a comment
andrewwinters5000
left a comment
Member
There was a problem hiding this comment.
Everything looks good from my side. I also updated all of the Benchmark PlotFiles and StatsFiles as they can be useful for debugging. That is why it tens of thousands of lines are indicated as changed.
The only substantive change I made is now the Benchmarks/ControlFiles/AllFeatures.control is the same as the one present in Examples/2D/AllFeatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with marking the joints in curve chains, but also adds new functionality that smoothes the boundary node distributions so that elements will have more uniform edge sizes along boundaries.