Draft
Conversation
Member
|
You need to change |
Add `adapt_structure` for VariableSearchRadiusNHS, PairsNHSHandler, VariableNHSHandler. Add documentation for nhs handlers and variable search radius nhs. Export VariableSearchRadiusNHS, PairsNHSHandler, VariableNHSHandler. Replace `create_neighborhood_search_handler()` with outer constructor. Sort the search_radii before calling `searchsortedfirst`. Add basic test for the different nhs handlers.
Add search_radius arg to `PointNeighbors.foreach_point_neighbor`. Fix the NHS Handler unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NHS Handler for variable neighborhood search.