Extend shared rigid contact runtime model#1123
Open
svchb wants to merge 21 commits intotrixi-framework:mainfrom
Open
Extend shared rigid contact runtime model#1123svchb wants to merge 21 commits intotrixi-framework:mainfrom
svchb wants to merge 21 commits intotrixi-framework:mainfrom
Conversation
efaulhaber
requested changes
Apr 13, 2026
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
…/TrixiParticles.jlOpen into port/rigid-contact-runtime
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
+ Coverage 89.00% 89.05% +0.05%
==========================================
Files 128 128
Lines 9838 9888 +50
==========================================
+ Hits 8756 8806 +50
Misses 1082 1082
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps PR1 focused on active rigid-contact runtime behavior: rigid contact stays normal-only, while contact_count and max_contact_penetration are added as diagnostics in system data, VTK output, and regression tests. The PR also fixes their lifecycle so they are recomputed per interaction pass, remain thread-safe, and stay available for output callbacks.
These diagnostics are useful now for monitoring contact in tests and ParaView, and later for richer contact features in follow-up PRs.