fix(docker): install git — the image has been unbuildable since June - #10
Closed
trogers1052 wants to merge 1 commit into
Closed
fix(docker): install git — the image has been unbuildable since June#10trogers1052 wants to merge 1 commit into
trogers1052 wants to merge 1 commit into
Conversation
pip shells out to git to install git+https dependencies. risk-engine's
pyproject and requirements.txt both pull trading-py-commons that way, as
does decision-engine's own requirements.txt, but python:3.12-slim ships no
git binary, so the build dies at:
ERROR: Cannot find command 'git' - do you have 'git' installed
Timeline: the last successful image build was 2026-04-17; risk-engine
adopted trading-py-commons on 2026-06-03. No push to main has happened
since, so CI never re-ran and the break went unnoticed for ~8 weeks. The
Pi is therefore running an April image, and any redeploy would have failed
at the worst possible moment.
Found while building the service for an e2e-replay run. Verified by
building unmodified main (fails) and main+git (succeeds).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Owner
Author
|
Closing as already fixed. The diagnosis stands and is worth recording: the image was unbuildable from The identical fix in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
pipshells out togitto installgit+httpsdependencies. Bothrisk-engine(via its pyproject/requirements) and this repo'srequirements.txtpulltrading-py-commonsthat way, butpython:3.12-slimships no git binary, so the build dies at:
Why it went unnoticed
risk-engineadoptedtrading-py-commonsmainsinceThe Pi is therefore running an April image, and the next redeploy would have
failed at whatever moment it happened to be attempted.
Verification
Built unmodified
main(fails atpip install /tmp/risk-engine/) andmainplus this one line (succeeds). Found while building the service for an
e2e-replay run.
The same fix is needed in
realtime-data-analytics, filed separately.🤖 Generated with Claude Code