Add opower to mypy pre-commit additional_dependencies#188
Draft
loganrosen wants to merge 1 commit into
Draft
Conversation
The mypy pre-commit hook runs in an isolated environment that only has the packages listed in additional_dependencies. Without opower itself, mypy fails with import-not-found errors when checking test files that import from the opower package. This only manifested during git commit (which passes only changed files to mypy), not during CI (which uses --all-files, allowing mypy to resolve imports from the src/ tree).
tronikos
requested changes
May 1, 2026
| - pyotp | ||
| - pytest-mypy | ||
| - python-dotenv | ||
| - opower |
Owner
There was a problem hiding this comment.
Won't this pull from PyPI, not your local working tree?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mypy pre-commit hook runs in an isolated environment that only has the packages listed in
additional_dependencies. Withoutopoweritself, mypy fails withimport-not-founderrors when checking test files that import from the opower package.This only manifests during
git commit(which passes only changed files to mypy), not during CI (which uses--all-files, allowing mypy to resolve imports from thesrc/tree).