feat(*): disable market transaction #6499
Open
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3for
reviewed
Dec 26, 2025
| testAllowTvmSelfdestructRestrictionProposal(); | ||
|
|
||
| thrown = assertThrows(ContractValidateException.class, r1); | ||
| assertEquals("Bad chain parameter id [ALLOW_MARKET_TRANSACTION]", thrown.getMessage()); |
There was a problem hiding this comment.
Should the boundary version be explicitly set here?
forkUtils.getManager().getDynamicPropertiesStore().statsByVersion(
ForkBlockVersionEnum.VERSION_4_8_1.getValue(), stats);
3for
reviewed
Dec 26, 2025
| ThrowingRunnable open = () -> ProposalUtil.validator(dynamicPropertiesStore, forkUtils, | ||
| ProposalType.ALLOW_MARKET_TRANSACTION.getCode(), 1); | ||
|
|
||
| ContractValidateException thrown = assertThrows(ContractValidateException.class, open); |
There was a problem hiding this comment.
Is there implicit version information here?
Contributor
Author
There was a problem hiding this comment.
Bad chain parameter id [ALLOW_MARKET_TRANSACTION] since 4.8.1, like this?
I noticed that the previous notice lacked version information. Is the newly added version information meant to distinguish between versions before 4.1 and versions 4.8.1 and later?
3for
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disable market transaction since 4.8.1.
Why are these changes required?
Market transaction is not used.
This PR has been tested by:
Follow up
Extra details