fix: improve slurp() robustness with size limit and read loop#12
Merged
imichaelmoore merged 1 commit intoNov 29, 2025
Merged
Conversation
Owner
|
Can you rebase this and resolve the conflict? |
Addresses several issues in slurp(): 1. No size limit - A large dependency file could exhaust memory 2. Partial reads - read() can return fewer bytes than requested 3. EINTR - Interrupted system calls weren't retried Fix: - Add 10MB size limit (SLURP_MAX_SIZE) - Read in a loop until all bytes are received - Retry on EINTR - Log malloc failures Note: Preserves the TOCTOU fix from PR #9 (fstat after open).
imichaelmoore
force-pushed
the
fix-slurp-memory-safety
branch
from
November 29, 2025 18:47
855c958 to
a5f5415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several issues in
slurp():read()can return fewer bytes than requested; the code treated this as an errorFix:
SLURP_MAX_SIZE)EINTR