fix: code quality improvements across all core scripts#6
Merged
Conversation
- Sort imports alphabetically (isort/Ruff I rule) - Replace broad Exception catches with specific OSError - Use Optional[T] instead of T = None for type hints - Remove debug print statements from plugin_manager.py - Remove internal import (re) already at module level in analyze_project.py - Move json import to top level in generate_toc.py - Fix single-line if statements in analyze_project.py (Ruff E701) - Remove traceback.print_exc() from plugin_manager.py error handler All 8 scripts verified to compile cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Systematic code quality improvements across all 8 core Python scripts, addressing issues that Ruff and mypy would flag.
Changes
Import Sorting (all 8 files)
Sorted imports alphabetically following isort conventions (Ruff I rule):
Exception Handling
detect_changes.py:Exception→OSErrorfor file hash calculationplugin_manager.py: Removedtraceback.print_exc()from error handlerType Annotations
detect_changes.py:Set[str] = None→Optional[Set[str]] = None(3 functions)analyze_project.py: Same fix fordiscover_modulesDead Code Removal
plugin_manager.py: Removed 5 debugprint()statementsanalyze_project.py: Removed redundantimport reinside function (already at module level)generate_toc.py: Movedimport jsonfrom inside function to module levelStyle Fixes
analyze_project.py: Split single-lineifstatements onto separate lines (Ruff E701)Verification
All 8 scripts verified to compile cleanly with
python3 -m py_compile.Statistics
🤖 Generated with Claude Code