Skip to content

feat(search): complete PR #33850 with Zoekt UI translations and search mode coverage#1

Open
Copilot wants to merge 3 commits into
mainfrom
copilot/update-gitea-pull-33850
Open

feat(search): complete PR #33850 with Zoekt UI translations and search mode coverage#1
Copilot wants to merge 3 commits into
mainfrom
copilot/update-gitea-pull-33850

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 7, 2026

This updates the branch to fully reflect the Zoekt code-search work from go-gitea#33850 and closes the remaining review gap where Zoekt search labels rendered as missing translation keys.
The change set is intentionally minimal: bring in the upstream Zoekt implementation, then add the missing English locale entries and a focused unit test.

Description

  • Zoekt code-search support

    • Cherry-picked upstream feat(search): support code search by zoekt changeset.
    • Includes Zoekt-backed code indexer/search wiring, settings, and dependency integration.
  • Missing UI translation keys

    • Added missing English locale keys used by SearchModeZoekt:
      • search.zoekt
      • search.zoekt_tooltip
    • Prevents untranslated key names from appearing in search mode UI.
  • Focused regression coverage

    • Added modules/indexer/indexer_test.go to assert ZoektSearchModes() exposes the Zoekt mode with the expected title/tooltip translation keys.
assert.Contains(t, ZoektSearchModes(), SearchMode{
    ModeValue:    SearchModeZoekt,
    TooltipTrKey: "search.zoekt_tooltip",
    TitleTrKey:   "search.zoekt",
})

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • code.onedev.io
    • Triggering command: /tmp/go-build629789337/b2249/migrations.test /tmp/go-build629789337/b2249/migrations.test -test.testlogfile=/tmp/go-build629789337/b2249/testlog.txt -test.paniconexit0 -test.timeout=10m0s --64�� u/13/liblto_plugin.so _64-linux-gnu/13/lto-wrapper Ac2yGL.res -o s l/linux_amd64/ve/usr/libexec/gcc/x86_64-linux-gnu/13/liblto_plugin.so /x86_64-linux-gn-plugin-opt=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper s -o (dns block)
  • devstoreaccount1.azurite.local
    • Triggering command: /tmp/go-build629789337/b2043/storage.test /tmp/go-build629789337/b2043/storage.test -test.testlogfile=/tmp/go-build629789337/b2043/testlog.txt -test.paniconexit0 -test.timeout=10m0s ortc�� /usr/libexec/gcc/x86_64-linux-gnu/13/liblto_plugin.so stmain.go ux-amd64/pkg/tool/linux_amd64/compile -plugin-opt=-pasas -plugin-opt=-pas--64 -plugin-opt=-pas-o ux-amd64/pkg/too/tmp/ccuH1LoB.o --64�� 789337/b1983/conda.test /tmp/ccywsA6Z.o (dns block)
  • elasticsearch
    • Triggering command: /tmp/go-build629789337/b1917/elasticsearch.test /tmp/go-build629789337/b1917/elasticsearch.test -test.testlogfile=/tmp/go-build629789337/b1917/testlog.txt -test.paniconexit0 -test.timeout=10m0s x86-�� -o /tmp/go-link-125--hash-style=gnu /usr/bin/ld /tmp/go-link-125as dels/user/badge.--64 ux-amd64/pkg/too-o /usr/bin/ld -plu�� u/13/liblto_plugin.so _64-linux-gnu/13/lto-wrapper rg/toolchain@v0.0.1-go1.26.0.linux-amd64/pkg/tool/linux_amd64/vet d s tation rg/toolchain@v0./tmp/ccvmP9ro.o (dns block)
    • Triggering command: /tmp/go-build878430625/b1052/elasticsearch.test /tmp/go-build878430625/b1052/elasticsearch.test -test.testlogfile=/tmp/go-build878430625/b1052/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build878430625/b960/vet.cfg /internal/timese-errorsas rg/toolchain@v0.-ifaceassert ux-amd64/pkg/tool/linux_amd64/vet --gdwarf-5 tea/modules/auth-atomic mpile ux-amd64/pkg/too-buildtags 4306�� _.a om/!proton!mail/-ifaceassert ux-amd64/pkg/tool/linux_amd64/vet . /minio-go/v7/pkg-atomic mpile ux-amd64/pkg/too-buildtags (dns block)
  • gitlab.com
    • Triggering command: /tmp/go-build629789337/b2249/migrations.test /tmp/go-build629789337/b2249/migrations.test -test.testlogfile=/tmp/go-build629789337/b2249/testlog.txt -test.paniconexit0 -test.timeout=10m0s --64�� u/13/liblto_plugin.so _64-linux-gnu/13/lto-wrapper Ac2yGL.res -o s l/linux_amd64/ve/usr/libexec/gcc/x86_64-linux-gnu/13/liblto_plugin.so /x86_64-linux-gn-plugin-opt=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper s -o (dns block)
  • meilisearch
    • Triggering command: /tmp/go-build629789337/b1921/meilisearch.test /tmp/go-build629789337/b1921/meilisearch.test -test.testlogfile=/tmp/go-build629789337/b1921/testlog.txt -test.paniconexit0 -test.timeout=10m0s x86-�� -o /tmp/ccjIDCBD.o /usr/bin/gcc g_.a /tmp/cc7Vxmjc.o nwind-tables r-strong -m64�� y otection rg/toolchain@v0.0.1-go1.26.0.linux-amd64/pkg/tool/linux_amd64/compile c t l/linux_amd64/li/tmp/go-build629789337/b1920/_pkg_.a rg/toolchain@v0.-trimpath (dns block)
    • Triggering command: /tmp/go-build878430625/b1056/meilisearch.test /tmp/go-build878430625/b1056/meilisearch.test -test.testlogfile=/tmp/go-build878430625/b1056/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build878430625/b962/vet.cfg 1.78.0/grpclog/i-errorsas 1.78.0/grpclog/i-ifaceassert ux-amd64/pkg/tool/linux_amd64/vet -p ons/jobparser mpile ux-amd64/pkg/too-buildtags pkg/�� _.a mpile ux-amd64/pkg/tool/linux_amd64/vet . tea/modules/auth-atomic mpile ux-amd64/pkg/too-buildtags (dns block)
  • smtp.mydomain.test
    • Triggering command: /tmp/go-build629789337/b2037/setting.test /tmp/go-build629789337/b2037/setting.test -test.testlogfile=/tmp/go-build629789337/b2037/testlog.txt -test.paniconexit0 -test.timeout=10m0s s -o stmain.go de/node/bin/as -o (dns block)
    • Triggering command: /tmp/go-build351283730/b001/setting.test /tmp/go-build351283730/b001/setting.test -test.testlogfile=/tmp/go-build351283730/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s estl�� pkg/mod/github.c-pthread t rg/toolchain@v0.-fmessage-length=0 -p github.com/bleve-o t rg/toolchain@v0.-trimpath (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

adlternative and others added 2 commits March 7, 2026 01:02
Signed-off-by: ZheNing Hu <adlternative@gmail.com>
(cherry picked from commit e674078)
Co-authored-by: trucpd <92442070+trucpd@users.noreply.github.com>
Copilot AI changed the title [WIP] Update pull request 33850 feat(search): complete PR #33850 with Zoekt UI translations and search mode coverage Mar 7, 2026
@trucpd trucpd marked this pull request as ready for review March 7, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants