Remove top-level await in module to improve browser compatibility
#1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I can understand the idea. But I'd expect all those browsers to be EOL. Even with extended support. And I don't feel like we could ever test that. |
Author
|
Ok, thanks, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top-level await in a module is a compatibility bottle-neck for my app:
With this PR, for example, I can run my app in Chrome 87 on my 2015 Macbook. Without this PR, I get a syntax error on that device. In general, this PR helps with browsers older than early 2021.
Alternatives
Trunk could respect the
WasmBindgenTarget::NoModulesconfiguration option when generating HTML.