fix(scan): accept a VERSION pin without the v prefix - #35
Open
Paramjeet-singh-neu wants to merge 1 commit into
Open
fix(scan): accept a VERSION pin without the v prefix#35Paramjeet-singh-neu wants to merge 1 commit into
Paramjeet-singh-neu wants to merge 1 commit into
Conversation
Release tags are v0.1.7. VERSION=0.1.7 built a download URL under /download/0.1.7/ which 404s. Prepend v when the pin has no prefix. The README example was v0.5.0, a tag that does not exist; use v0.1.7. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release tags are
v0.1.7. PinningVERSION=0.1.7(nov) built:https://github.com/trustabl/trustabl/releases/download/0.1.7/trustabl_0.1.7_…which 404s against tag
v0.1.7. The wrapper now prependsvwhen the pin has no prefix.latestis unchanged (the API already returnsv0.1.7).The README example was
v0.5.0, a tag that does not exist. Replaced withv0.1.7.Test plan
bash test/version-tag.sh—0.1.7→v0.1.7;v0.1.7staysVERSION=0.1.7on a CodeBuild project and confirm the download URL includes/download/v0.1.7/Made with Cursor