chore(scan): drop four unused definitions - #37
Open
joeymussalli wants to merge 1 commit into
Open
Conversation
Each of these is written once and never referenced again:
- SCAN_START and SCAN_END capture timestamps around the scan, but nothing
reads them -- not the console report, not trustabl-summary.md, not
trustabl.env. shellcheck flags both as SC2034.
- md_emoji() and md_count() render emoji progress bars ("🟩🟩⬜⬜", "▰▰▱▱") and
are never called. They were clearly written for the markdown summary, which
currently emits a plain severity table instead.
Removing them takes the script to zero shellcheck findings at warning level
(it was two), which makes it practical to gate on that later.
Worth a maintainer's opinion: md_emoji and md_count could equally be *wired in*
rather than deleted, giving trustabl-summary.md the same visual treatment the
console report already gets. Deleting is the smaller, more reversible change,
so that is what this does -- happy to switch it to the other one instead.
No behaviour change: the removed names had no readers, `bash -n` passes, and
nothing else in the script referenced them.
joeymussalli
force-pushed
the
chore/remove-dead-code
branch
from
August 24, 2026 20:05
dcf3fec to
81341c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of these is written once and never referenced again:
Removing them takes the script to zero shellcheck findings at warning level (it was two), which makes it practical to gate on that later.
Worth a maintainer's opinion: md_emoji and md_count could equally be wired in rather than deleted, giving trustabl-summary.md the same visual treatment the console report already gets. Deleting is the smaller, more reversible change, so that is what this does -- happy to switch it to the other one instead.
No behaviour change: the removed names had no readers,
bash -npasses, and nothing else in the script referenced them.