fix(buildspec): fail install when jq or curl cannot be installed - #44
Open
Paramjeet-singh-neu wants to merge 1 commit into
Open
Conversation
The install commands hid yum/apt failure behind || true, so a missing jq or curl became a confusing scan error (or a score from a run that never started). Fail the install phase instead. Also list BRANCH and DEBUG in the input comment — both are read by the scanner, neither was documented next to the other CodeBuild env vars. Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
sheel-PBM
added a commit
to sheel-PBM/trustabl-aws
that referenced
this pull request
Aug 24, 2026
Leave install fail-closed to trustabl#44 and repo-wide CI to the dedicated lint PRs. This change is REPORT_ONLY plus Security Hub ASFF only. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CodeBuild install phase hid a failed `jq` / `curl` install behind `|| true`. On an image that does not already have them, the scan then died later with a confusing command-not-found (or, if the script's own fallbacks also fail, reported a score from a run that never started).
Fail the install phase instead so CodeBuild stops at the missing toolchain. Also list `BRANCH` and `DEBUG` in the input comment — both are read by `scan/trustabl-scan.sh`, neither was documented next to the other env vars. Complementary to the README `BRANCH`/`DEBUG` PR; this is the file CodeBuild users actually copy.
Does not touch `scan/trustabl-scan.sh`.
Test plan
Made with Cursor