feat(langchain): detect Requests calls without timeout - #115
Open
pjsk02 wants to merge 1 commit into
Open
Conversation
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
LC-007to detect Pythonrequestscalls without a finite timeout inside LangChain tools.LangChain Python currently lacks equivalent timeout coverage while similar network-timeout rules exist for other supported SDKs. This adds that coverage using Trustabl''s existing
call_without_kwargpredicate without requiring engine or schema changes.Detection
LC-007fires for supportedrequestscalls inside LangChain tools when:timeoutis omittedtimeout=NoneIt remains silent when an explicit finite timeout is supplied.
The rule intentionally does not flag
httpxmerely because a call omits an explicittimeout, since HTTPX provides default timeout behavior.Scope
This contribution is intentionally limited to Python Requests call-site detection.
Known limitations include wrapper functions, dynamically configured client defaults, positional timeout handling, and HTTP libraries outside the current Requests-specific scope.
Validation
call_without_kwargpredicate reusedgit diff --checkpassesCompanion PRs