feat(google_adk): add ADK-115, ADK-116 tool description quality rules - #89
Open
bradAGI wants to merge 1 commit into
Open
feat(google_adk): add ADK-115, ADK-116 tool description quality rules#89bradAGI wants to merge 1 commit into
bradAGI wants to merge 1 commit into
Conversation
Ports the CSDK-017/018 description-quality pair to the Google ADK. ADK-001 only checks that a docstring exists, so a tool whose docstring reads "TODO" or "Gets data." passes today while giving the model no selection signal. Two ADK-specific points. The ADK parses the docstring for the per-parameter descriptions that accompany the generated schema, so a placeholder or one-clause docstring strips argument-level guidance at the same time as tool-level guidance. And in an agent tree the mis-selection does not stay local: a tool picked wrongly inside one branch produces output the following agents treat as established fact, so the error is laundered into shared session state rather than surfacing where it began. ADK-102/107's before_tool_callback can block a call it recognizes as wrong but cannot supply the judgment the description was meant to give. Numbered ADK-115/116 to leave room for ADK-111 in the open PR trustabl#51 and the IDs used by my other open PRs.
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the CSDK-017/018 description-quality pair (merged in #40) to the Google ADK. ADK-001 only checks that a docstring exists, so a tool whose docstring reads
"""TODO: describe this tool."""or"""Gets data."""passes today while giving the model no selection signal.Two ADK-specific points:
ADK-116 also names the mitigation people would reach for and why it isn't one: ADK-102 and ADK-107's
before_tool_callbackcan block a call it recognizes as wrong, but it can't supply the judgment the description was meant to provide. A callback doesn't compensate for a thin description.Numbered ADK-115/116 to leave room for ADK-111 in the open PR #51 and the IDs used by my other open PRs (#79, #86).
Verification — engine built at
main:Fire (one
FunctionTool-wrapped function with"""TODO: describe this tool.""", one with"""Gets data."""):ADK-115, ADK-116, ADK-201Silent (full docstring with an
Args:section):ADK-201ADK-116 pairs
description_length_lt: 40withhas_docstring: trueso it doesn't double-report against ADK-001 on an empty docstring, same as CSDK-018.No new predicates, so no
schema_versionbump.