test(langchain): add LC-103 fixture coverage - #175
Open
jiaxinaspenlin-dotcom wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the engine-side fixture and test coverage for LC-103, which detects LangChain agents that wire
langchain_community'sRequests*built-in HTTP tools.What changed
testdata/rules-fixture/langchain/agent_safety.yamlinternal/rules/policies_test.goCoverage includes:
ReactAgentwithRequestsGetToolAgentExecutorwithRequestsPostToolReactAgentwithTavilySearchResultsEvery
AgentDefsetsLanguage.No analyzer changes were required because the existing LangChain hosted-tool discovery already recognizes all five
Requests*classes.Validation
go vet ./...— passgo test -race ./internal/rules/...— passgo test -race ./...— 26 packages passed, 0 failuresgo build -o /tmp/trustabl ./cmd/trustabl— passcheck-rules-sync.sh— in sync with productionThe fixture is byte-identical to the corresponding rule definition in
trustabl-rules.Paired changes
All coordinated changes use the shared branch:
feat/langchain-requests-builtin-tool