Skip to content

fix(test): de-flake the KEV inline-due-date test (date time bomb) #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haksungjang merged 1 commit into from
Jul 8, 2026
Merged

fix(test): de-flake the KEV inline-due-date test (date time bomb) #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/frontend/tests/unit/features/projects/VulnerabilityDetailBody.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,19 @@ describe("VulnerabilityDetailBody", () => {
});

it("renders the KEV badge with the inline due date for a KEV-listed finding", () => {
renderBody({ kev: true, kev_due_date: "2026-07-15" });
// Far-future due date on purpose: this surface (VulnerabilityDetailBody)
// does NOT inject a `now` into KevBadge, so the inline text is computed
// against the real clock. A near date would flip to the relative
// "Due in n days" format (dueDateStatus imminent window is 7 days) and make
// this assertion date-dependent — the exact time bomb this replaces. The
// state-aware relative/absolute formatting is covered deterministically in
// KevBadge.test.tsx via its injected `now`.
renderBody({ kev: true, kev_due_date: "2099-12-31" });
const badge = screen.getByTestId("kev-badge");
expect(badge.textContent).toContain("KEV");
// Drawer surface renders the CISA remediation due date inline.
expect(screen.getByTestId("kev-badge-due-date").textContent).toContain(
"2026-07-15",
"2099-12-31",
);
});

Expand Down
Loading