Add Redis distributed lock so sweep workers run on a single active instance - #257
Merged
meshackyaro merged 2 commits intoAug 30, 2026
Merged
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DistributedLockService(src/common/redis/distributed-lock.service.ts) — RedisSET key token NX PX ttllease + compare-and-delete release (Lua). Wired intoGigExpiryWorkerServiceandRepinWorkerService: each tick acquires a fresh lock (TTL = 1.5x the sweep interval) before runningrunOnce(), skips the tick if another instance holds it, and releases explicitly ononModuleDestroy. IfREDIS_CLIENTisnull(REDIS_URLunset), locking fails open — every instance runs independently with a warning logged, preserving today's single-instance behavior instead of silently disabling the sweep; this is documented in the service's doc comment. Existing worker specs updated to inject a fake lock and still pass; newdistributed-lock.service.spec.tscovers concurrent-acquire racing (exactly one winner), release/re-acquire, compare-and-delete (can't release a lock you don't hold), and the fail-open path. Closes Add distributed lock so background sweep workers run as a single active instance #182