fix: correlation ID logging, Swagger docs accuracy, Discord timeout - #362
Merged
Conversation
closes trustflow-protocol#247 - Add CorrelationIdMiddleware (AsyncLocalStorage) that generates/propagates X-Request-Id for every request; threads the ID through SentryExceptionFilter as a Sentry tag so Sentry events can be cross-referenced with application logs; adds LoggingModule wired globally via AppModule.configure(); includes unit tests asserting ID propagation, concurrent request isolation, and inbound header propagation. closes trustflow-protocol#246 - Correct overstated Swagger global description in main.ts: 'all endpoints' rate limiting claim replaced with accurate per-endpoint scoping (authenticated = per-IP + per-wallet, unauthenticated = IP-only); added per-tag notes on Escrow and Webhooks controllers flagging that those endpoints are currently unauthenticated. closes trustflow-protocol#242 - Add explicit 5 s timeout to DiscordService.sendWebhook() via the https.request options.timeout field and a req.on('timeout') handler that calls req.destroy(); a hung Discord connection no longer blocks raiseDispute or escalate callers. Test added using a mock TCP server that never responds, asserting notifyDisputeNeedsJurors() resolves within the timeout window. closes trustflow-protocol#243 - (unassigned, no changes made)
|
@OlaGreat Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #247 - Add CorrelationIdMiddleware (AsyncLocalStorage) that generates/propagates X-Request-Id for every request; threads the ID through SentryExceptionFilter as a Sentry tag so Sentry events can be cross-referenced with application logs; adds LoggingModule wired globally via AppModule.configure(); includes unit tests asserting ID propagation, concurrent request isolation, and inbound header propagation.
closes #246 - Correct overstated Swagger global description in main.ts: 'all endpoints' rate limiting claim replaced with accurate per-endpoint scoping (authenticated = per-IP + per-wallet, unauthenticated = IP-only); added per-tag notes on Escrow and Webhooks controllers flagging that those endpoints are currently unauthenticated.
closes #242 - Add explicit 5 s timeout to DiscordService.sendWebhook() via the https.request options.timeout field and a req.on('timeout') handler that calls req.destroy(); a hung Discord connection no longer blocks raiseDispute or escalate callers. Test added using a mock TCP server that never responds, asserting notifyDisputeNeedsJurors() resolves within the timeout window.