Add buffered feature support to port 200 & 201#165
Merged
michaelbeutler merged 3 commits intomainfrom Sep 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds buffered uplink feature support to the TagXL v1 decoder for port 200 and port 201 payloads by implementing the required interface methods and updating payload configurations.
- Implements the
UplinkFeatureBufferedinterface for bothPort200PayloadandPort201Payloadstructs - Adds
decoder.FeatureBufferedto the features list for all port 200 and 201 payload configurations - Defines buffered status based on timestamp age (messages older than 5 minutes are considered buffered)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/decoder/tagxl/v1/decoder.go | Updates payload configurations to include decoder.FeatureBuffered feature |
| pkg/decoder/tagxl/v1/port200.go | Implements UplinkFeatureBuffered interface methods and adds interface assertion |
| pkg/decoder/tagxl/v1/port201.go | Implements UplinkFeatureBuffered interface methods for Port201Payload |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
niko-kriznik-globtim
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request adds support for the buffered uplink feature to the TagXLv1 decoder, allowing it to identify when an uplink is considered "buffered" based on its age. The implementation introduces a centralized threshold for buffered status and updates the payload structs and configuration logic to reflect this new feature.
Buffered uplink feature support:
bufferedAgeThresholdinconstants.goto define the age after which an uplink is considered buffered, centralizing the threshold value for easier maintenance.decoder.FeatureBufferedflag to theFeatureslist ingetConfigfor relevant port/version combinations indecoder.go, ensuring the decoder advertises support for buffered uplinks. [1] [2] [3] [4]Payload struct enhancements:
decoder.UplinkFeatureBufferedinterface for bothPort200PayloadandPort201Payload, including stubGetBufferLevelmethods and theIsBufferedmethod, which uses the centralized threshold to determine buffered status based on timestamp age. [1] [2]