Skip to content

fix(release): bind Stage packaging to exact private head #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
try-works merged 2 commits into from
Aug 31, 2026
Merged

fix(release): bind Stage packaging to exact private head #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f217461
fix(release): require exact private stage head
try-works Aug 31, 2026
6632790
style(release): format provenance contract test
try-works Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,9 @@ jobs:
exit 1
fi
git fetch --no-tags origin "+refs/heads/${REQUIRED_PRIVATE_BRANCH}:refs/remotes/origin/${REQUIRED_PRIVATE_BRANCH}"
if ! git merge-base --is-ancestor "$RELEASE_PRIVATE_SHA" "origin/$REQUIRED_PRIVATE_BRANCH"; then
echo "Private revision must be promoted through role-model-internal/$REQUIRED_PRIVATE_BRANCH before $ROLE_MODEL_BUILD_CHANNEL packaging."
required_private_head="$(git rev-parse "origin/$REQUIRED_PRIVATE_BRANCH")"
if [[ "$RELEASE_PRIVATE_SHA" != "$required_private_head" ]]; then
echo "Paired private revision must equal the current role-model-internal/$REQUIRED_PRIVATE_BRANCH head before $ROLE_MODEL_BUILD_CHANNEL packaging."
exit 1
fi

Expand Down
6 changes: 5 additions & 1 deletion scripts/build-binaries-workflow.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ test("the public release orchestrator enforces paired private promotion", () =>
assert.match(workflow, /fetch-depth: 0/);
assert.match(workflow, /Verify private revision passed paired promotion branch/);
assert.match(workflow, /REQUIRED_PRIVATE_BRANCH:[\s\S]*?'main'[\s\S]*?'stage'/);
assert.match(workflow, /git merge-base --is-ancestor/);
assert.match(
workflow,
/required_private_head="\$\(git rev-parse "origin\/\$REQUIRED_PRIVATE_BRANCH"\)"/,
);
assert.match(workflow, /\[\[ "\$RELEASE_PRIVATE_SHA" != "\$required_private_head" \]\]/);
});

test("paired private checkout never dirties the public package provenance worktree", () => {
Expand Down
Loading