Fix #109: Dynamically set agency in QueryRenderer for TTC support#156
Open
iamlegendharsh wants to merge 2 commits intotrynmaps:masterfrom
Open
Fix #109: Dynamically set agency in QueryRenderer for TTC support#156iamlegendharsh wants to merge 2 commits intotrynmaps:masterfrom
iamlegendharsh wants to merge 2 commits intotrynmaps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue:
(also, start the PR title with the issue #)
Description
What does your PR add/resolve and which parts of the codebase are affected?
Testing
We don't have any automated testing at the moment; this is to ensure that we don't break things until we have automated tests.
The map loads [Y/N]
Selecting a route shows it on the map, along with its vehicles [Y/N]
Changing the time to an hour in the past results in the vehicles changing their locations [Y/N]
Changing the city to Toronto and selecting route 6 results in stop/vehicles appearing (in the downtown area) [Y/N]
Does the web-app look the same as the master branch? [Y/N]
If not, attach a screenshot or describe how it looks.