Skip to content

Direct Samsung Health includes uses non primitive types for primitive types. Inconsistent with master branch #20

Description

@itsramiel

Hi,

A while ago I submitted a pr to fix types to use primitive types which is the expected types used and the pr was merged. However the samsung sdk branch is not using primitive types.

Example from main:

terra-react/src/index.ts

Lines 28 to 31 in 8b5bd8e

export type SuccessMessage = {
success: boolean;
error: string | null;
};

Example from android-samsung-sdk:

terra-react/src/index.ts

Lines 25 to 28 in 7d2ef82

export type SuccessMessage = {
success: Boolean;
error: String | null;
};

This causes typescript issues for library users

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions