style: change default delimeter to be ": " instead of "="#531
Open
okt-limonikas wants to merge 3 commits into
Open
style: change default delimeter to be ": " instead of "="#531okt-limonikas wants to merge 3 commits into
okt-limonikas wants to merge 3 commits into
Conversation
okt-limonikas
force-pushed
the
replace-delimeter
branch
3 times, most recently
from
046ff69 to
59ed2b2
Compare
okt-limonikas
force-pushed
the
replace-delimeter
branch
3 times, most recently
from
479773e to
17ac732
Compare
Currently we use "=" as a delimeter for `<key>=<value>` pairs and use "=" also in API requests make this behaviour configurable via global app config and display in ": " as a default delimeter. This change is backward compatible with current usage of "=", so users can use both "=" and ": " when filling out forms. Signed-off-by: Danil Kostromin <danil.kostromin@icloud.com>
The config import was added to the run/test/verdict search sections but never used, leaving the BadgeFields without delimiter props (and tripping no-unused-vars). Pass config.keyValueDisplay/SubmitDelimiter through so the parameter/tag/etc. inputs format and normalize consistently with the rest of the app. Signed-off-by: Danil Kostromin <danil.kostromin@icloud.com>
normalizeRunDataQuery hardcoded ';' for both split and join while the rest of the codebase (history-slice, analytics, run-endpoints, router) uses config.queryDelimiter. Source the separator from config so runData parsing stays correct if the delimiter is ever reconfigured. Signed-off-by: Danil Kostromin <danil.kostromin@icloud.com>
okt-limonikas
force-pushed
the
replace-delimeter
branch
from
17ac732 to
46db185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we use "=" as a delimeter for
<key>=<value>pairs and use "=" also in API requests make this behaviour configurable via global app config and display in ": " as a default delimeter. This change is backward compatible with current usage of "=", so users can use both "=" and ": " when filling out forms.