Skip to content

🔒 Fix Arbitrary Command Execution via OIL_SYSTEM_PREFIX in testing - #237

Open
undivisible wants to merge 1 commit into
mainfrom
fix-oil-system-prefix-env-leak-17662094030822357210
Open

undivisible wants to merge 1 commit into
mainfrom
fix-oil-system-prefix-env-leak-17662094030822357210

Conversation

@undivisible

@undivisible undivisible commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The resolve_install_dest_without_prefix test spawned the test executable but only removed the OIL_SYSTEM_PREFIX environment variable, allowing it to inherit all other variables.
⚠️ Risk: Inheriting environment variables in self-executing tests could lead to unexpected behavior or arbitrary command execution via variables like LD_PRELOAD or other shell configurations.
🛡️ Solution: Modified the test to use .env_clear() instead of .env_remove("OIL_SYSTEM_PREFIX") to ensure the subprocess starts with a clean environment.


PR created automatically by Jules for task 17662094030822357210 started by @undivisible


Note

Low Risk
Test-only change to subprocess environment setup; no production install-path or runtime behavior is modified.

Overview
Hardens the resolve_install_dest_without_prefix test when it re-executes the test binary in a subprocess (when OIL_SYSTEM_PREFIX is set in the parent). The subprocess launcher now uses .env_clear() instead of .env_remove("OIL_SYSTEM_PREFIX"), so the child no longer inherits the full parent environment.

That closes a test-only footgun where variables like LD_PRELOAD or other inherited config could alter subprocess behavior or widen arbitrary execution risk during self-spawned test runs.

Reviewed by Cursor Bugbot for commit c0a42c4. Configure here.

Replaced `.env_remove("OIL_SYSTEM_PREFIX")` with `.env_clear()` in
`system/oil/src/util/security.rs` when spawning the test executable to
prevent inheriting the parent's environment variables.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_5bffd434-51f2-4727-a4cf-edf857c653bd)

@mergify

mergify Bot commented Sep 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant