Skip to content

🧪 Add missing tests and safe bounds check for parseCarrier - #238

Open
undivisible wants to merge 1 commit into
mainfrom
add-parse-carrier-test-8973271323252674980
Open

undivisible wants to merge 1 commit into
mainfrom
add-parse-carrier-test-8973271323252674980

Conversation

@undivisible

@undivisible undivisible commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The testing gap for parseCarrier in system/alpenglow-ctl/src/network.zig has been addressed. An issue where the function panicked on an empty string was also fixed.
📊 Coverage: Tests verify the correct mapping of '0' to false, '1' to true, invalid strings to null, null to null, and empty strings to null.
Result: Increased test coverage and a bugfix that makes parseCarrier more robust against bad input without panicking.


PR created automatically by Jules for task 8973271323252674980 started by @undivisible


Note

Low Risk
Small defensive input handling in sysfs parsing plus unit tests; no auth or data-path changes.

Overview
parseCarrier in network.zig now returns null for empty strings instead of indexing the first byte, which could panic when sysfs carrier values are missing or malformed.

A unit test mirrors the existing parseKind coverage: null, "0"/"1" (including trailing newline), invalid values, and empty strings all map to the expected ?bool results used when building interface snapshots for netd.

Reviewed by Cursor Bugbot for commit 5a899bd. Configure here.

…ing inputs.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_a5d371d2-7528-44d7-b5ac-905d9485a2f8)

@mergify

mergify Bot commented Sep 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant