🧪 Add missing tests and safe bounds check for parseCarrier - #238
undivisible wants to merge 1 commit into
Conversation
…ing inputs. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a5d371d2-7528-44d7-b5ac-905d9485a2f8) |
|
Tick the box to add this pull request to the merge queue (same as
|
🎯 What: The testing gap for
parseCarrierinsystem/alpenglow-ctl/src/network.zighas been addressed. An issue where the function panicked on an empty string was also fixed.📊 Coverage: Tests verify the correct mapping of
'0'tofalse,'1'totrue, invalid strings tonull,nulltonull, and empty strings tonull.✨ Result: Increased test coverage and a bugfix that makes
parseCarriermore robust against bad input without panicking.PR created automatically by Jules for task 8973271323252674980 started by @undivisible
Note
Low Risk
Small defensive input handling in sysfs parsing plus unit tests; no auth or data-path changes.
Overview
parseCarrierinnetwork.zignow returnsnullfor empty strings instead of indexing the first byte, which could panic when sysfs carrier values are missing or malformed.A unit test mirrors the existing
parseKindcoverage:null,"0"/"1"(including trailing newline), invalid values, and empty strings all map to the expected?boolresults used when building interface snapshots for netd.Reviewed by Cursor Bugbot for commit 5a899bd. Configure here.