chore: orb setup, PR CI, clippy-clean CLI paths - #20
Merged
Merged
Conversation
Install rustup/cargo on fresh Amp orbs, keep resume fast, and run fmt/clippy/test on pull requests. Exclude new repo files from the root Swift package and take Path instead of PathBuf in the dev loop. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a632-0bd5-7371-8f63-23825bae184c Co-authored-by: Max Carter <undivisible@vk.com>
|
Capy couldn't review this pull request because Max's workspace is out of credits, add credits or enable auto-reload to resume automatic reviews. |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Amp orb bootstrap (
.agents/setup/.agents/resume), a pull-request CI workflow (fmt/clippy/test), and small packaging/CLI hygiene so those files do not break SwiftPM.Why
Fresh orbs had no
rustc/cargo. Release CI only ran on tags, so PRs had no checks.Notes
-D warningson the existing CLIPathBufargs would fail the new CI, so those signatures are&Path.Test plan
bash -n .agents/setup .agents/resumerustc/cargocargo test --workspace --lockedandcargo clippy --workspace --all-targets -- -D warnings