Skip to content

🧪 [testing improvement] Add missing tests for TimeRange value parsing - #21

Merged
undivisible merged 2 commits into
mainfrom
add-time-range-tests-15723490004744232020
Sep 2, 2026
Merged

undivisible merged 2 commits into
mainfrom
add-time-range-tests-15723490004744232020

Conversation

@undivisible

@undivisible undivisible commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🎯 What: Added tests for the TimeRange enum string mapping methods (as_str and value).
📊 Coverage: Covered all variants of TimeRange (Day, Week, Month, Year) for both as_str and value methods.
Result: Improved test coverage and reliability for TimeRange value parsing.


PR created automatically by Jules for task 15723490004744232020 started by @undivisible


Note

Low Risk
Test-only change with no runtime or API behavior impact.

Overview
Adds a unit test time_range_as_str_and_value_are_correct in src/lib.rs that locks in string output for every TimeRange variant (Day, Week, Month, Year) via as_str() and value().

There is no production code change—only regression coverage for the mappings used when building search query strings (e.g. time_range=week).

Reviewed by Cursor Bugbot for commit a2cf9e8. Configure here.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@undivisible
undivisible merged commit 694c0cc into main Sep 2, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant