🧪 [Testing Improvement] Add test for cache configuration update - #22
🧪 [Testing Improvement] Add test for cache configuration update#22undivisible wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
Cache keys are (embedded, mode, query) after the collision fix; the clear_cache unit test still inserted a bare String and failed to compile.
9471fa6 to
c08f13a
Compare
🎯 What: The testing gap addressed was the lack of unit test to ensure that
with_cachebuilder correctly updates thecache_capacityandcache_ttl.📊 Coverage: The test covers the happy path to guarantee that
cache_settings()yields exactly what was provided viawith_cache(capacity, ttl).✨ Result: Enhanced test coverage ensures no future regressions concerning standard object manipulation within
SearchConfig.PR created automatically by Jules for task 6866043697458891038 started by @undivisible
Note
Low Risk
Test-only change with no runtime or API behavior impact.
Overview
Adds a unit test
search_config_with_cache_updates_capacity_and_ttlinsrc/lib.rssoSearchConfig::with_cache(128, 120s)is checked viacache_settings()for the expected capacity and TTL.No production code changes—only test coverage for the existing builder/getter pair on
SearchConfig.Reviewed by Cursor Bugbot for commit 9471fa6. Configure here.