Skip to content

🧪 Add dedicated tests for WebsurfxQuery builder - #25

Merged
undivisible merged 2 commits into
mainfrom
add-websurfxquery-builder-tests-13495370272218540200
Sep 2, 2026
Merged

undivisible merged 2 commits into
mainfrom
add-websurfxquery-builder-tests-13495370272218540200

Conversation

@undivisible

@undivisible undivisible commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The testing gap addressed is the missing isolated tests for the with_safe_search and with_page builders on WebsurfxQuery.
📊 Coverage: The scenarios now tested involve calling each builder and verifying that the internal property is mutated correctly.
Result: The improvement ensures builder logic for WebsurfxQuery remains intact across refactors.


PR created automatically by Jules for task 13495370272218540200 started by @undivisible


Note

Low Risk
Test-only change with no modifications to production code or runtime behavior.

Overview
Adds two unit tests in websurfx.rs that exercise WebsurfxQuery builders one at a time: sets_safe_search_level_on_query checks with_safe_search(4) sets safe_search() to Some(4), and sets_page_on_query checks with_page(2) sets page() to Some(2).

Existing gets_websurfx_query_properties already chains both builders; these tests lock in each setter independently so refactors are less likely to break builder behavior without a focused failure.

Reviewed by Cursor Bugbot for commit 47d13aa. Configure here.

This adds dedicated test cases for `with_safe_search` and `with_page` in
`src/websurfx.rs`, improving test coverage for the builder pattern per user request.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@undivisible
undivisible merged commit 7b8c126 into main Sep 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant