🧹 Fix dead code in compiler pipeline - #320
Conversation
Replaced `#[allow(dead_code)]` with `#[cfg(test)]` on the `backend` field in `Compiler`. Properly gated `BackendKind` import and local variable assignments in `Compiler::new` to prevent unused variable/import warnings in non-test configurations. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_771b5ce0-637e-4e28-afc4-0f46f80822be) |
|
Tick the box to add this pull request to the merge queue (same as
|
🎯 What: The
backendfield in theCompilerstruct (in-cli/src/compiler/pipeline.rs) was using an#[allow(dead_code)]attribute because it was only being read during tests.💡 Why: Removing the
dead_codeallowance and properly gating the field and its related imports behind#[cfg(test)]accurately reflects the usage of the field, improving code health and maintainability by not carrying unused state in production binaries.✅ Verification: Verified by running
cargo check,cargo fmt,cargo test, andcargo clippy --all-targets --features extended --locked -- -D warningsacross thein-clipackage. Ensured both test and non-test targets build without warnings or errors.✨ Result: The codebase is cleaner and correctly reflects that the
backendfield is strictly a testing artifact, eliminating a broad compiler lint suppression.PR created automatically by Jules for task 783568647677168508 started by @undivisible
Note
Low Risk
Test-only struct layout change with no production behavior change beyond dropping unused state.
Overview
Gates the
Compilerstruct’sbackendfield and theBackendKindimport behind#[cfg(test)], and removes#[allow(dead_code)]. Production builds still validate the backend viaselect_backendinCompiler::new, but no longer store the resolved kind on the struct.Test-only behavior is unchanged:
compiler_resolves_backend_kindcan still assertcompiler.backendmatches the host triple.Reviewed by Cursor Bugbot for commit 037184d. Configure here.