Skip to content

🧹 Fix dead code in compiler pipeline - #320

Open
undivisible wants to merge 1 commit into
masterfrom
fix-dead-code-compiler-pipeline-783568647677168508
Open

🧹 Fix dead code in compiler pipeline#320
undivisible wants to merge 1 commit into
masterfrom
fix-dead-code-compiler-pipeline-783568647677168508

Conversation

@undivisible

@undivisible undivisible commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The backend field in the Compiler struct (in-cli/src/compiler/pipeline.rs) was using an #[allow(dead_code)] attribute because it was only being read during tests.

💡 Why: Removing the dead_code allowance and properly gating the field and its related imports behind #[cfg(test)] accurately reflects the usage of the field, improving code health and maintainability by not carrying unused state in production binaries.

Verification: Verified by running cargo check, cargo fmt, cargo test, and cargo clippy --all-targets --features extended --locked -- -D warnings across the in-cli package. Ensured both test and non-test targets build without warnings or errors.

Result: The codebase is cleaner and correctly reflects that the backend field is strictly a testing artifact, eliminating a broad compiler lint suppression.


PR created automatically by Jules for task 783568647677168508 started by @undivisible


Note

Low Risk
Test-only struct layout change with no production behavior change beyond dropping unused state.

Overview
Gates the Compiler struct’s backend field and the BackendKind import behind #[cfg(test)], and removes #[allow(dead_code)]. Production builds still validate the backend via select_backend in Compiler::new, but no longer store the resolved kind on the struct.

Test-only behavior is unchanged: compiler_resolves_backend_kind can still assert compiler.backend matches the host triple.

Reviewed by Cursor Bugbot for commit 037184d. Configure here.

Replaced `#[allow(dead_code)]` with `#[cfg(test)]` on the `backend` field in `Compiler`.
Properly gated `BackendKind` import and local variable assignments in `Compiler::new` to prevent unused variable/import warnings in non-test configurations.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_771b5ce0-637e-4e28-afc4-0f46f80822be)

@mergify

mergify Bot commented Sep 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant