Skip to content

🧪 Test segmentToPattern function in packages/compiler - #97

Open
undivisible wants to merge 1 commit into
mainfrom
test/discover-segment-to-pattern-16732758744540747067
Open

🧪 Test segmentToPattern function in packages/compiler#97
undivisible wants to merge 1 commit into
mainfrom
test/discover-segment-to-pattern-16732758744540747067

Conversation

@undivisible

@undivisible undivisible commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The testing gap for segmentToPattern in packages/compiler/src/discover.ts was addressed by implementing the missing unit tests.
📊 Coverage: The test cases now cover:

  • Static segments mapped unchanged
  • Dynamic segments ([slug]) correctly mapped to required parameters (:slug)
  • Optional dynamic segments ([[slug]]) mapped to optional parameters (:slug?)
  • Catch-all segments ([...slug]) converted to wildcard parameters (*slug)
    Result: Enhanced test coverage that guarantees proper path segment evaluation and URL template formatting stability.

PR created automatically by Jules for task 16732758744540747067 started by @undivisible


Note

Low Risk
Test-only changes with no production code modifications.

Overview
Adds dedicated unit tests for segmentToPattern in discover.test.ts, covering static segments, [param], [[optional]], and [...catch-all]:param, :param?, and *param respectively.

The test file now imports segmentToPattern alongside discoverRoutes from ../src/discover.js (explicit .js extension on the module path).

Reviewed by Cursor Bugbot for commit 824aa70. Configure here.

* Imported `segmentToPattern` in `packages/compiler/test/discover.test.ts`.
* Added `describe` block testing static, dynamic, optional dynamic, and catch-all path segment processing mapping.
* Executed local compiler tests and verified formatting constraints.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_a144b682-12ed-4f94-8ba3-8c091ca63e1f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant