chore: add orb setup and pin CI checkout - #53
Merged
Merged
Conversation
Install the MSRV and stable Rust toolchains, plugin deps, and AT-SPI headers from a fresh orb. Pin actions/checkout to v4.4.0, run clippy on MSRV, and inline a 1.88 format-args lint in a CDP config test. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a632-d0b9-760e-a38f-da94049550f9 Co-authored-by: Max Carter <undivisible@vk.com>
|
Capy couldn't review this pull request because Max's workspace is out of credits, add credits or enable auto-reload to resume automatic reviews. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_73633dd8-9617-424a-940a-35ebf2ee09cd) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agents/setupand.agents/resumeso Amp orbs install MSRV 1.88 + stable Rust, AT-SPI/D-Bus headers, OpenClaw bun deps, and Hermes ruff/ty..amp/portals/*.actions/checkoutto11d5960a326750d5838078e36cf38b85af677262(v4.4.0) in every CI job.cargo clippy -D warningson the MSRV job so 1.88 lints cannot regress (CI rust matrix uses stable, which currently does not emit this lint).format!("{process_generation}-stale")in a CDP invalid-config test.Audit notes (no extra PRs)
Jules PRs #1–#52 are merged or recovered via #51. No open PRs/issues. Security boundaries (library-only
execute,DenyAuthorityCLI, fenced targets, loopback CDP + PID ownership, host-injected Ed25519) look intact. Not auto-merging: CI/control-path change. No crates.io publish.Test plan
.agents/setupcold ~42s, warm ~2s;.agents/resume<1scargo fmt --all -- --checkcargo clippy --locked --all-targets --all-features -- -D warningson 1.88 and stablecargo test --locked --all-features(170 tests)test_plugin.py+ ruffNote
Low Risk
Mostly dev-environment and CI workflow changes; MSRV clippy may surface new build failures but does not alter runtime security paths.
Overview
Adds Amp orb bootstrap via executable
.agents/setup(system deps, Rust 1.88 + stable with fmt/clippy,cargo fetch, optional OpenClawbun install, Hermes dev venv) and.agents/resume(fast toolchain presence checks). Ignores.amp/portals/*in git.CI pins
actions/checkoutto commit v4.4.0 across jobs and runscargo clippy -D warningson the MSRV 1.88 job so lints that stable might miss still fail on minimum Rust.One test-only tweak in
cdp.rs: inlineformat!("{process_generation}-stale")in an invalid-config assertion.Reviewed by Cursor Bugbot for commit d5a946a. Configure here.