Skip to content

🧪 [Testing] Add edge case tests for texture atlas dimensions - #84

Merged
undivisible merged 2 commits into
mainfrom
test-texture-atlas-dimensions-17554464297751629176
Jun 16, 2026
Merged

undivisible merged 2 commits into
mainfrom
test-texture-atlas-dimensions-17554464297751629176

Conversation

@undivisible

Copy link
Copy Markdown
Contributor

🎯 What: The missing edge case tests for TextureAtlas::dimensions() have been added in src/cache/texture_atlas.rs.
📊 Coverage: The new test test_atlas_dimensions_edge_cases covers extreme value ranges for width and height: zeroes (0, 0), u32::MAX boundaries (u32::MAX, u32::MAX), and mixed boundaries (0, u32::MAX).
Result: Test coverage for texture_atlas.rs is improved, ensuring robustness of basic dimension data accessors.


PR created automatically by Jules for task 17554464297751629176 started by @undivisible

Adds unit tests asserting `dimensions()` returns correct values for
0x0, u32::MAX, and mixed dimensions edge cases in `TextureAtlas`.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@undivisible
undivisible force-pushed the test-texture-atlas-dimensions-17554464297751629176 branch from 0994400 to a2b42cc Compare June 16, 2026 11:09
@undivisible
undivisible merged commit 6c5cb32 into main Jun 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant