Skip to content

🧹 refactor: Extract suggestion logic from CommandBar.svelte - #95

Merged
undivisible merged 1 commit into
mainfrom
fix-commandbar-suggestions-8566463460012556513
Jun 16, 2026
Merged

undivisible merged 1 commit into
mainfrom
fix-commandbar-suggestions-8566463460012556513

Conversation

@undivisible

Copy link
Copy Markdown
Contributor

🎯 What: Extracted the suggestion logic from CommandBar.svelte into a new suggestions.ts utility file.
💡 Why: CommandBar.svelte was extremely long and conflated UI markup with complex fuzzy search, filtering, and scoring logic. Extracting this improves readability and allows unit testing the suggestion algorithms without mounting the component.
Verification: Ran bun run check locally to ensure zero Svelte compilation or typing errors. Re-verified store reactivity by explicitly passing stores ({ browser, tabCounts }) to $: reactive declarations. Verified no unresolved imports.
Result: A leaner CommandBar.svelte focused purely on UI orchestration. No behavioral changes.


PR created automatically by Jules for task 8566463460012556513 started by @undivisible

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@undivisible
undivisible force-pushed the fix-commandbar-suggestions-8566463460012556513 branch from 34dda11 to 0c1c051 Compare June 16, 2026 10:59
@undivisible
undivisible force-pushed the fix-commandbar-suggestions-8566463460012556513 branch from 0c1c051 to c260f60 Compare June 16, 2026 11:02
@undivisible
undivisible merged commit 2dfadfc into main Jun 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant