Skip to content

feat(personalities): real NTSTATUS/LastError + Darwin errno maps #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
undivisible merged 1 commit into from
Aug 20, 2026
Merged

feat(personalities): real NTSTATUS/LastError + Darwin errno maps #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 172 additions & 2 deletions components/darwin.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ package space.kernel
// mkdir=136, rmdir=137, stat=188, fstat=189, getcwd=192, mmap=197, lseek=199, munmap=73
// Open flags: BSD/Darwin O_CREAT=0x200, O_TRUNC=0x400 (mapped onto VFS-O-*).
// Optional Mach stubs: task_self trap 0x1000 → 1; mach_msg 0x1001 → -1.
// errno: negative dispatch results land in darwin-errno-last; read via 0x2000 (__error()).
// Pipe lite: max 4 pipes, 4KB ring; vfs fd type field (+24) = 2, pipe idx at +8.

const DARWIN-SYS-EXIT = 1
Expand Down Expand Up @@ -67,6 +68,12 @@ const DARWIN-AF-INET = 2
const DARWIN-MACH-TASK-SELF = 0x1000
const DARWIN-MACH-MSG = 0x1001

// Space-local errno shims (not BSD syscall numbers): __error() read/write.
const DARWIN-SYS-ERRNO = 0x2000
const DARWIN-SYS-SETERRNO = 0x2001

var darwin-errno-last: Int = 0

const DARWIN-ESRCH = -3
const DARWIN-EBADF = -9
const DARWIN-ENOENT = -2
Expand Down Expand Up @@ -141,6 +148,9 @@ fn darwin-errno(vfs-rc: Int) -> Int {
if vfs-rc == -2 {
return DARWIN-ENOENT
}
if vfs-rc == -3 {
return DARWIN-ESRCH
}
if vfs-rc == -5 {
return DARWIN-EIO
}
Expand All @@ -159,7 +169,13 @@ fn darwin-errno(vfs-rc: Int) -> Int {
if vfs-rc == -28 {
return DARWIN-ENOSPC
}
return DARWIN-ENOSYS
if vfs-rc == -12 {
return DARWIN-ENOMEM
}
if vfs-rc == -38 {
return DARWIN-ENOSYS
}
return DARWIN-EINVAL
Comment on lines +175 to +178

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Convert VFS errors to Darwin errno numbers

The new errno slot still exposes Linux/VFS-shaped numbers rather than Darwin values: an unknown syscall maps -38 to errno 38 even though Darwin's ENOSYS is 78, while exhausting the VFS descriptor table makes vfs-open return -16, which falls through here to EINVAL (22) instead of Darwin EMFILE (24). Darwin callers inspecting the newly added errno slot therefore receive incorrect compatibility results for these failures.

Useful? React with 👍 / 👎.

}

// Map BSD/Darwin open flags onto Space VFS flags (Linux-shaped bits under the hood).
Expand Down Expand Up @@ -651,7 +667,7 @@ fn darwin-sys-recvfrom(fd: Int, buf: Int, len: Int) -> Int {
}

// BSD/Mach-ish dispatch. a0..a3 carry classic arg slots (open mode in a2, kill sig in a1).
fn darwin-dispatch(port: Int, num: Int, a0: Int, a1: Int, a2: Int, a3: Int) -> Int {
fn darwin-dispatch-call(port: Int, num: Int, a0: Int, a1: Int, a2: Int, a3: Int) -> Int {
if darwin-ready == 0 {
darwin-init()
}
Expand Down Expand Up @@ -763,6 +779,158 @@ fn darwin-dispatch(port: Int, num: Int, a0: Int, a1: Int, a2: Int, a3: Int) -> I
return DARWIN-ENOSYS
}

// BSD errno discipline: every negative dispatch result lands in the per-personality
// errno slot, readable through the __error() shim. Success never clears it.
fn darwin-dispatch(port: Int, num: Int, a0: Int, a1: Int, a2: Int, a3: Int) -> Int {
if darwin-ready == 0 {
darwin-init()
}
if num == DARWIN-SYS-ERRNO {
return darwin-errno-last
}
if num == DARWIN-SYS-SETERRNO {
darwin-errno-last = a0
return 0
}
let rc = darwin-dispatch-call(port, num, a0, a1, a2, a3)
if rc < 0 {
darwin-errno-last = 0 - darwin-errno(rc)
}
Comment on lines +795 to +798

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Record zero-valued getcwd failures in errno

When getcwd receives a buffer too small for the current path, posix-sys-getcwd returns 0, but this wrapper updates errno only for negative results. The call therefore fails while leaving darwin-errno-last stale instead of reporting ERANGE, so the new errno contract is not end-to-end for this existing Darwin syscall; the dispatch layer needs either syscall-specific failure detection or normalized negative error returns.

Useful? React with 👍 / 👎.

return rc
}

// errno number → short name, so serial logs are readable without a lookup table.
fn darwin-errno-name(err: Int) -> Int {
if err == 0 {
return "0"
}
if err == 0 - DARWIN-ENOENT {
return "ENOENT"
}
if err == 0 - DARWIN-ESRCH {
return "ESRCH"
}
if err == 0 - DARWIN-EIO {
return "EIO"
}
if err == 0 - DARWIN-EBADF {
return "EBADF"
}
if err == 0 - DARWIN-ENOMEM {
return "ENOMEM"
}
if err == 0 - DARWIN-EACCES {
return "EACCES"
}
if err == 0 - DARWIN-EEXIST {
return "EEXIST"
}
if err == 0 - DARWIN-EINVAL {
return "EINVAL"
}
if err == 0 - DARWIN-ENOSPC {
return "ENOSPC"
}
if err == 0 - DARWIN-ENOSYS {
return "ENOSYS"
}
return "EUNKNOWN"
}

fn darwin-errno-demo(port: Int) -> void {
let checks = 0
let ok = 0

// open(missing, O_RDONLY) → ENOENT.
darwin-dispatch(port, DARWIN-SYS-OPEN, "darwin-err-nosuch.txt", DARWIN-O-RDONLY, 0, 0)
let e1 = darwin-dispatch(port, DARWIN-SYS-ERRNO, 0, 0, 0, 0)
serial-write-cstr(port, "darwin: errno after open(missing) = ")
serial-write-dec-wide(port, e1)
serial-write-cstr(port, " (")
serial-write-cstr(port, darwin-errno-name(e1))
serial-write-cstr(port, ")")
serial-nl(port)
checks = checks + 1
if e1 == 0 - DARWIN-ENOENT {
ok = ok + 1
}

// read on an unopened fd → EBADF.
let rbuf = alloc(16)
darwin-dispatch(port, DARWIN-SYS-READ, 15, rbuf, 8, 0)
let e2 = darwin-dispatch(port, DARWIN-SYS-ERRNO, 0, 0, 0, 0)
serial-write-cstr(port, "darwin: errno after read(bad fd) = ")
serial-write-dec-wide(port, e2)
serial-write-cstr(port, " (")
serial-write-cstr(port, darwin-errno-name(e2))
serial-write-cstr(port, ")")
serial-nl(port)
checks = checks + 1
if e2 == 0 - DARWIN-EBADF {
ok = ok + 1
}

// kill on a pid that does not exist → ESRCH.
darwin-dispatch(port, DARWIN-SYS-KILL, 99999, SIGKILL, 0, 0)
let e3 = darwin-dispatch(port, DARWIN-SYS-ERRNO, 0, 0, 0, 0)
serial-write-cstr(port, "darwin: errno after kill(invalid) = ")
serial-write-dec-wide(port, e3)
serial-write-cstr(port, " (")
serial-write-cstr(port, darwin-errno-name(e3))
serial-write-cstr(port, ")")
serial-nl(port)
checks = checks + 1
if e3 == 0 - DARWIN-ESRCH {
ok = ok + 1
}

// Unknown syscall number → ENOSYS.
darwin-dispatch(port, 60000, 0, 0, 0, 0)
let e4 = darwin-dispatch(port, DARWIN-SYS-ERRNO, 0, 0, 0, 0)
serial-write-cstr(port, "darwin: errno after unknown syscall = ")
serial-write-dec-wide(port, e4)
serial-write-cstr(port, " (")
serial-write-cstr(port, darwin-errno-name(e4))
serial-write-cstr(port, ")")
serial-nl(port)
checks = checks + 1
if e4 == 0 - DARWIN-ENOSYS {
ok = ok + 1
}

// A successful call must leave errno untouched (BSD semantics).
darwin-dispatch(port, DARWIN-SYS-GETPID, 0, 0, 0, 0)
let e5 = darwin-dispatch(port, DARWIN-SYS-ERRNO, 0, 0, 0, 0)
serial-write-cstr(port, "darwin: errno after getpid() = ")
serial-write-dec-wide(port, e5)
serial-nl(port)
checks = checks + 1
if e5 == e4 {
ok = ok + 1
}

// Explicit reset through the shim.
darwin-dispatch(port, DARWIN-SYS-SETERRNO, 0, 0, 0, 0)
let e6 = darwin-dispatch(port, DARWIN-SYS-ERRNO, 0, 0, 0, 0)
checks = checks + 1
if e6 == 0 {
ok = ok + 1
}

serial-write-cstr(port, "darwin: errno scenarios ")
serial-write-dec-wide(port, ok)
serial-write-cstr(port, "/")
serial-write-dec-wide(port, checks)
serial-nl(port)
if ok == checks {
serial-write-cstr(port, "darwin: errno consistency OK")
} else {
serial-write-cstr(port, "darwin: errno consistency FAILED")
}
serial-nl(port)
return
}

fn darwin-demo(port: Int) -> void {
if darwin-ready == 0 {
darwin-init()
Expand Down Expand Up @@ -1070,6 +1238,8 @@ fn darwin-demo(port: Int) -> void {
}
serial-nl(port)

darwin-errno-demo(port)

let task = darwin-dispatch(port, DARWIN-MACH-TASK-SELF, 0, 0, 0, 0)
serial-write-cstr(port, "darwin: mach_task_self stub = ")
serial-write-dec-wide(port, task)
Expand Down
Loading
Loading