Skip to content

Fix OBJ loader cache key#873

Open
hobyt-aluzar wants to merge 1 commit into
tscircuit:mainfrom
hobyt-aluzar:codex/fix-obj-cache-key
Open

Fix OBJ loader cache key#873
hobyt-aluzar wants to merge 1 commit into
tscircuit:mainfrom
hobyt-aluzar:codex/fix-obj-cache-key

Conversation

@hobyt-aluzar
Copy link
Copy Markdown

@hobyt-aluzar hobyt-aluzar commented May 11, 2026

Summary

  • add a stable OBJ loader cache key that ignores only cachebust_origin
  • keep loading the original model URL so request behavior does not change
  • cover cache-key normalization for repeated model URLs with tests

Testing

  • npx.cmd bun x biome format src/hooks/use-global-obj-loader.ts tests/use-global-obj-loader.test.ts
  • npx.cmd bun test tests/use-global-obj-loader.test.ts
  • npx.cmd bun x tsc --noEmit

Fixes #93
/claim #93

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment May 11, 2026 11:42pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve 3d model loading to avoid laggy browser

1 participant