Support STL CAD models in the shared loader#876
Open
nurik-1618 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MixedStlModelso extensionless CDN URLs can still use the right loadermodel_stl_urlresponses as OBJ textcachebust_originand namespacing by loader typeFixes a remaining model-loading gap for #93.
/claim #93
Verification
bun test tests/global-model-loader.test.tsbun x biome check src/AnyCadComponent.tsx src/hooks/use-global-obj-loader.ts src/three-components/MixedStlModel.tsx tests/global-model-loader.test.tsbun x tsc --noEmitbun run buildbun run test:node-bundlegit diff --checkFull test note
bun testhas 3 existing unrelated failures on current main expectations: twotests/preprocess-circuit-json.test.tsz-offset assertions expect 0.8/1.8 while current output is 0.7/1.7, andtests/outline-bounds.test.tsexpectsrgb(39,89,56)while current output contains nearby soldermask colors. The new focused STL loader test passes.