Detect model extensions before query strings#879
Open
jorgeschulz wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/claim #93
getModelFileExtensionsoload3DModeldetects file type from the URL path before query/hash suffixesmodel.glb?cachebust_origin=...being treated as unsupported.glb,.obj,.stl, and.wrlURLs with query/hash suffixesVerification
npx --yes bun@latest test tests/load-model-url-extension.test.tsnpx --yes bun@latest x tsc --noEmitnpx --yes bun@latest x biome check src/utils/load-model.ts tests/load-model-url-extension.test.tsnpx --yes bun@latest run buildgit diff --checkFull test note
npx --yes bun@latest testhas 3 existing unrelated failures on current main: twotests/preprocess-circuit-json.test.tsz-offset assertions expect0.8/1.8while current output is0.7/1.7, andtests/outline-bounds.test.tsexpectsrgb(39,89,56)while current SVG contains nearby soldermask colors.AI-assisted with Codex; I reviewed the diff and ran the checks above before opening this PR.