Clone cached OBJ models safely#884
Open
phungkaizen wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
phungkaizen
commented
May 13, 2026
Author
There was a problem hiding this comment.
Hi maintainers, I added validation details for this focused OBJ cached clone fix.
Validation:
- GitHub checks are passing, including test, type-check, and format-check.
- Vercel preview is Ready.
- The PR includes regression coverage for cached OBJ clone behavior.
Minimal demo/GIF plan:
- Open a preview scene with repeated OBJ models using the same source URL.
- Confirm the model is loaded through the cache path.
- Confirm each rendered instance has an independent cloned Object3D tree.
- Confirm geometry is reused while materials are cloned per instance, so hover/transparency state does not leak between repeated models.
I’m happy to add an actual short GIF/video if needed for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloneLoadedObjectso cached OBJ loads return independent object trees while reusing geometry.Fixes #93
/claim #93
Review & Testing Checklist for Human
Notes
Tested locally:
bun test tests/global-obj-loader-cache.test.tsbun run buildbunx --bun tsc --noEmitFull
bun testcurrently has pre-existing failures unrelated to this change in existing outline/preprocess suites.