Cache STEP model conversions by normalized URL#885
Open
newmattock wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
newmattock
force-pushed
the
codex/step-model-cache-key-93
branch
from
f3dbe0e to
6c392d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #93
Summary
cachebust_originfrom the STEP URLstepUrlfor fetching and converting, so meaningful query params still reach the model servercachebust_originplacement, hashes, and meaningful query paramsNon-overlap
The active PRs I found cover OBJ loader cache keys, GLTF/GLB loader caching, STL shared-loader behavior, and generic
load3DModelURL detection. This PR only touches the STEP-to-GLB path inStepModel.Verification
bun test /Users/jakehatchett/Documents/Codex/2026-05-11/can-you-make-a-goal-for/3d-viewer/tests/step-model-cache-key.test.tsgit diff --checkAI-assisted with Codex; I reviewed the diff before submitting.